gh-149965: Improve thread-safety in ElementObjects within element_ass_subscr#149966
Open
clin1234 wants to merge 3 commits into
Open
gh-149965: Improve thread-safety in ElementObjects within element_ass_subscr#149966clin1234 wants to merge 3 commits into
element_ass_subscr#149966clin1234 wants to merge 3 commits into
Conversation
element_ass_subscr
Commented out critical section assertion for ElementObject.
sergey-miryanov
requested changes
May 18, 2026
|
|
||
| // Pointer-by-pointer memmove for PyObject** arrays that is safe | ||
| // for shared ElementObjects in Py_GIL_DISABLED builds. | ||
| static void |
Contributor
There was a problem hiding this comment.
I'm not sure we should duplicate ptr_wise_atomic_memmove here.
Could you please link to the related C-API Working group issue in this PR, and cross-reference it in the original issue?
| @@ -0,0 +1 @@ | |||
| WIthin ``Modules/_elementtree.c``, improve thread-safety in ElementObjects within ``element_ass_subscr`` | |||
Contributor
There was a problem hiding this comment.
Suggested change
| WIthin ``Modules/_elementtree.c``, improve thread-safety in ElementObjects within ``element_ass_subscr`` | |
| Improve thread-safety of ElementObjects in ``element_ass_subscr`` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.